william/gitops-automation
1
0
Fork 0
Code Issues Pull Requests 3 Actions Packages Projects Releases Wiki Activity

Fix Hermes: gateway command + disable network-reachable API server #11

Merged
william merged 1 commits from fix/hermes-gateway-command-and-api-server into main 2026-08-23 15:52:35 +00:00
Conversation 1 Commits 1 Files Changed 1
+10 -5
claude-bot commented 2026-08-23 15:52:15 +00:00
Collaborator
Copy Link
Copy Source

Details in the commit message.

Details in the commit message.
claude-bot added 1 commit 2026-08-23 15:52:15 +00:00
Fix Hermes container: add gateway command, disable network-reachable API server 98762e764a 
Without an explicit command the image launches the interactive CLI by
default, which immediately exits with 'Input is not a terminal' in a
detached container — it was doing nothing on every restart. Also disables
API_SERVER_ENABLED: Hermes itself warns at startup that a network-reachable
API server combined with the default unsandboxed 'local' terminal backend
gives any caller on the network full terminal/file access. Not needed yet
(Matrix is the actual interface) — can re-enable properly (with a sandboxed
terminal backend) if claude-agent ever needs to call Hermes programmatically.
william merged commit c88fdcc2ea into main 2026-08-23 15:52:35 +00:00
claude-bot commented 2026-08-23 15:53:14 +00:00
Author
Collaborator
Copy Link
Copy Source

Reviewed the diff (docker-compose.yml only, +10/-5). The core fix — adding command: ["gateway", "run"] and disabling API_SERVER_ENABLED — is sound and well-justified by the commit message. Two minor cleanup nits surfaced, both non-blocking:

  1. .env.example still defines HERMES_API_SERVER_KEY, which is now dead since API_SERVER_KEY was dropped from the service.
  2. The "re-enable" comment tells a future maintainer to restore API_SERVER_HOST but doesn't mention that API_SERVER_KEY also needs restoring.

No correctness bugs found in the actual behavioral change.

Reviewed the diff (docker-compose.yml only, +10/-5). The core fix — adding `command: ["gateway", "run"]` and disabling `API_SERVER_ENABLED` — is sound and well-justified by the commit message. Two minor cleanup nits surfaced, both non-blocking: 1. `.env.example` still defines `HERMES_API_SERVER_KEY`, which is now dead since `API_SERVER_KEY` was dropped from the service. 2. The "re-enable" comment tells a future maintainer to restore `API_SERVER_HOST` but doesn't mention that `API_SERVER_KEY` also needs restoring. No correctness bugs found in the actual behavioral change.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
claude-bot william
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: william/gitops-automation#11